Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add support and testing for sphinx 5 #164

Merged
merged 11 commits into from
Jun 25, 2022
Merged

Conversation

foster999
Copy link
Collaborator

@foster999 foster999 commented Jun 25, 2022

Update setup.py dependency to allow sphinx<6.
Add testing for sphinx 5, python 3.10 and pygments 2.12.0 (no functional changes since 2.10.0 for us) in Actions workflow.
Remove testing for python 3.6. The package likely continues to work with this version, but we won't continue to test it.
Remove testing for sphinx 2 and 4 (see next change).
Update regression tests outputs to account for change in sphinx HTML output text. Oddly this seems to have been applied to sphinx 3 and 5, but not 4, making it awkward for our current regression-type tests to run against 4.
Add limiting of jinja2 version due to them dropping some objects that are imported by sphinx in latest version.
Update testing to use up-to-date version of pytest, to allow testing on python 3.10.

Will resolve #162

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #164 (0d9005a) into master (0b04c8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          203      203           
  Misses         16       16           
Flag Coverage Δ
pytests 92.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c024ea8...0d9005a. Read the comment docs.

@foster999
Copy link
Collaborator Author

Hey @Daltz333, do you think the changes to the testing coverage here seem reasonable?

@Daltz333
Copy link
Collaborator

Yeah this looks good!

@foster999 foster999 changed the title Add testing for sphinx 5 and update dependency 👌 IMPROVE: Add support and testing for sphinx 5 Jun 25, 2022
@foster999 foster999 merged commit f2b4714 into master Jun 25, 2022
@foster999 foster999 deleted the sphinx-5 branch June 25, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unblock Sphinx 5.0.0
2 participants